Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Node split demo #6592

Merged
merged 13 commits into from
Jan 9, 2025
Merged

[WIP] Node split demo #6592

merged 13 commits into from
Jan 9, 2025

Conversation

pigmej
Copy link
Member

@pigmej pigmej commented Jan 7, 2025 •
edited
Loading

Wip demo contents

@pigmej pigmej changed the base branch from develop to node-split-poc January 7, 2025 18:05
@pigmej pigmej changed the title [WIPNode split demo [WIP] Node split demo Jan 7, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.0%. Comparing base (a294344) to head (3b8860f).
Report is 15 commits behind head on node-split-poc.

Additional details and impacted files 
@@              Coverage Diff               @@
##           node-split-poc   #6592   +/-   ##
==============================================
  Coverage            77.0%   77.0%           
==============================================
  Files                 346     346           
  Lines               46373   46373           
==============================================
+ Hits                35718   35727    +9     
+ Misses               8524    8517    -7     
+ Partials             2131    2129    -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kacpersaw
kacpersaw reviewed Jan 7, 2025
View reviewed changes
activation_service_poc/docs/README.md Outdated Show resolved Hide resolved
activation_service_poc/docs/README.md Outdated Show resolved Hide resolved
activation_service_poc/docs/README.md Outdated Show resolved Hide resolved
activation_service_poc/docs/README.md Outdated Show resolved Hide resolved
noamnelke
noamnelke approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@noamnelke noamnelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Given this readme, I'm not sure we need any recorded demo - it seems to me to be enough.

activation_service_poc/docs/README.md Outdated Show resolved Hide resolved
activation_service_poc/docs/README.md Outdated Show resolved Hide resolved
@pigmej
Copy link
Member Author

pigmej commented Jan 8, 2025

I'll move the contents to the docs repo but please review /accept regardless.

@pigmej pigmej mentioned this pull request Jan 9, 2025
Merged
@pigmej
Copy link
Member Author

pigmej commented Jan 9, 2025

moved to: spacemeshos/docs#174

@pigmej pigmej closed this Jan 9, 2025
@pigmej pigmej reopened this Jan 9, 2025
@jellonek jellonek merged commit 6b44c13 into node-split-poc Jan 9, 2025
13 checks passed
@jellonek jellonek deleted the node-split-demo branch January 9, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monikasmolarek monikasmolarek monikasmolarek left review comments

@kacpersaw kacpersaw kacpersaw left review comments

@noamnelke noamnelke noamnelke approved these changes

@jellonek jellonek jellonek approved these changes

@dshulyak dshulyak Awaiting requested review from dshulyak dshulyak is a code owner

@fasmat fasmat Awaiting requested review from fasmat fasmat is a code owner

@poszu poszu Awaiting requested review from poszu poszu is a code owner

@ivan4th ivan4th Awaiting requested review from ivan4th ivan4th is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pigmej @jellonek @noamnelke @kacpersaw @monikasmolarek